On Fri, 2019-06-28 at 18:13 +0300, Oshri Alkoby wrote: The long descriptions are still missing. Please take the time and write a proper commit messages that clearly tell what the patch does. Check out tpm_tis_core.c and tpm_tis_spi.c. TPM TIS driver implements that spec so you should only implement a new physical layer. /Jarkko