On 02/07/2019 18:47, Olivier Moysan wrote: > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bindings. > > Fixes: 3f18021f43a3 ("dt-bindings: display: sii902x: Add HDMI audio bindings") > > Signed-off-by: Olivier Moysan <olivier.moysan@xxxxxx> Looking the specs again it looks like the mclk is requred for sii9020, but not for sii9022 and sii9024. So I guess it is fine to accept the configurations without the mclk. Reviewed-by: Jyri Sarha <jsarha@xxxxxx> > --- > Documentation/devicetree/bindings/display/bridge/sii902x.txt | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > index 2df44b7d3821..6e14e087c0d0 100644 > --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt > +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt > @@ -26,9 +26,8 @@ Optional properties: > - clocks: phandle and clock specifier for each clock listed in > the clock-names property > - clock-names: "mclk" > - Describes SII902x MCLK input. MCLK is used to produce > - HDMI audio CTS values. This property is required if > - "#sound-dai-cells"-property is present. This property follows > + Describes SII902x MCLK input. MCLK can be used to produce > + HDMI audio CTS values. This property follows > Documentation/devicetree/bindings/clock/clock-bindings.txt > consumer binding. > > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki