On Wed, Jul 3, 2019 at 1:58 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > Hi Rob, > > On Wed, Jul 03, 2019 at 08:20:32AM -0600, Rob Herring wrote: > > On Wed, Jul 3, 2019 at 8:13 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > > > > > On Wed, Jul 03, 2019 at 07:53:43AM -0600, Rob Herring wrote: > > > > On Wed, Jul 3, 2019 at 3:55 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > > > > > > > > > The child nodes of a mdio bus are supposed to be ethernet PHYs, with a reg > > > > > property. Make sure that's validated as well. > > > > > > > > I don't think this is always true. I seem to recall there's some > > > > timestamping devices connected via mdio. > > > > > > > > In any case, it's not a long list of names, so we can probably just > > > > enumerate them as needed. Does this generate any warnings? > > > > > > I did a run on both arm and arm64 Allwinner DTS, and it doesn't. > > > > > > I can do one on multi_v7 / arm64's defconfig, but that's probably > > > going to be a bit hard to tell from the noise of warnings. > > > > I do allmodconfig because that will build all dtbs. You can run checks > > with a single schema like this: > > > > make dtbs_check DT_SCHEMA_FILES=a-single-schema.yaml > > Right, of course :) > > I just did it, and apart from a few arm32 broadcom boards that don't > have the right address-cells / size-cells (probably false positive due > to the fact they use mdio@something as node name), there's no other > warnings. Actually, they look like real errors in the DT with the values of address-cells / size-cells swapped. But the node is disabled in the ones I looked at. > I'm not sure what you were on about though. If there's another node > than an ethernet phy, we won' have any warning since we don't have > additionalProperties to false. True. I guess I wasn't thinking through it... Anyways, I applied it. Rob
