On Tue, Jul 2, 2019 at 4:26 PM Abel Vesa <abel.vesa@xxxxxxx> wrote: > > On 19-06-26 15:45:15, Daniel Baluta wrote: > > On Tue, Jun 25, 2019 at 4:42 PM Abel Vesa <abel.vesa@xxxxxxx> wrote: > > > > > > Add the initial configuration for clocks that need default parent and rate > > > setting. This is based on the vendor tree clock provider parents and rates > > > configuration except this is doing the setup in dts rather than using clock > > > consumer API in a clock provider driver. > > > > > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxx> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 36 +++++++++++++++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > index 232a741..ab92108 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > > > @@ -451,6 +451,42 @@ > > > <&clk_ext3>, <&clk_ext4>; > > > clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2", > > > "clk_ext3", "clk_ext4"; > > > + assigned-clocks = <&clk IMX8MM_CLK_AUDIO_AHB>, > > > + <&clk IMX8MM_CLK_IPG_AUDIO_ROOT>, > > > + <&clk IMX8MM_SYS_PLL3>, > > > + <&clk IMX8MM_VIDEO_PLL1>, > > > + <&clk IMX8MM_CLK_NOC>, > > > + <&clk IMX8MM_CLK_PCIE1_CTRL>, > > > + <&clk IMX8MM_CLK_PCIE1_PHY>, > > > + <&clk IMX8MM_CLK_CSI1_CORE>, > > > + <&clk IMX8MM_CLK_CSI1_PHY_REF>, > > > + <&clk IMX8MM_CLK_CSI1_ESC>, > > > + <&clk IMX8MM_CLK_DISP_AXI>, > > > + <&clk IMX8MM_CLK_DISP_APB>; > > > + assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_800M>, > > > + <0>, > > Isn't there a macro for 0? (dummy clock?) > > I don't know about any such macro. If you're referring to IMX8MM_CLK_DUMMY, > that can't be used here since all I want here is to skip setting a parent to > the IMX8MM_CLK_IPG_AUDIO_ROOT. If I use IMX8MM_CLK_DUMMY (along with &clk) > it will set the parent to IMX8MM_CLK_DUMMY and that's not what's needed here. > > This is in accordance to the documentation: > > Documentation/devicetree/bindings/clock/clock-bindings.txt: > > "To skip setting parent or rate of a clock its corresponding entry should be > set to 0, or can be omitted if it is not followed by any non-zero entry." You are right. Thanks for the explanation!
