On Mon, Jul 01, 2019 at 05:27:22PM +0200, Pawel Dembicki wrote: > +static int vsc73xx_platform_read(struct vsc73xx *vsc, u8 block, u8 subblock, > + u8 reg, u32 *val) > +{ > + struct vsc73xx_platform *vsc_platform = vsc->priv; > + u32 offset; > + > + if (!vsc73xx_is_addr_valid(block, subblock)) > + return -EINVAL; > + > + offset = vsc73xx_make_addr(block, subblock, reg); > + > + mutex_lock(&vsc->lock); > + *val = ioread32be(vsc_platform->base_addr + offset); > + mutex_unlock(&vsc->lock); Hi Pawel What is this mutex protecting? Plus the indentation is wrong. Thanks Andrew