On Fri, Jun 28, 2019 at 7:47 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote: > > > > If the RNG wasn't initialised, we'd carry on with a warning. Why do we > > follow a different policy here? > > (Sorry, please ignore previous comment) I think this part should be same as kaslr, since they are both adding random seeds: If RNG isn't initialized, we won't be able to set these seeds, and dtb can't do anything else to deal with this, so carry on with warning. If fdt_setprop failed with no space, create_dtb() will try to setup dtb again with more space. Other failures are setting fdt's error, so returns invalid.