Hi, Leonard > -----Original Message----- > From: Leonard Crestez > Sent: Friday, June 28, 2019 2:01 PM > To: Anson Huang <anson.huang@xxxxxxx>; Jacky Bai <ping.bai@xxxxxxx>; > l.stach@xxxxxxxxxxxxxx > Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; shawnguo@xxxxxxxxxx; > s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; > viresh.kumar@xxxxxxxxxx; Daniel Baluta <daniel.baluta@xxxxxxx>; Abel > Vesa <abel.vesa@xxxxxxx>; andrew.smirnov@xxxxxxxxx; > ccaione@xxxxxxxxxxxx; angus@xxxxxxxx; agx@xxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH 2/2] arm64: dts: imx8mm: Correct OPP table according to > latest datasheet > > On 28.06.2019 06:37, Anson.Huang@xxxxxxx wrote: > > > According to latest datasheet (Rev.0.2, 04/2019) from below links, > > 1.8GHz is ONLY available for consumer part, so the market segment bits > > for 1.8GHz opp should ONLY available for consumer part accordingly. > > > > opp-hz = /bits/ 64 <1800000000>; > > opp-microvolt = <1000000>; > > /* Consumer only but rely on speed grading */ > > - opp-supported-hw = <0x8>, <0x7>; > > + opp-supported-hw = <0x8>, <0x3>; > > Only consumer parts should be fused for this highest OPP. If you don't want > to rely on this then maybe also delete the comment above? As I replied in previous i.MX8MQ patch, if the comments make reader confused, should we just remove all those comments? Thanks, Anson. > > -- > Regards, > leonard