Quoting Aniket Masule (2019-06-26 04:54:07) > This adds video nodes to sdm845 based on the examples > in the bindings. > > Signed-off-by: Malathi Gottam <mgottam@xxxxxxxxxxxxxx> There should be a From: line with this person's name in the email if they're the author. Otherwise this sign-off chain doesn't make sense and it should most likely have a Co-developed-by tag instead. > Signed-off-by: Aniket Masule <amasule@xxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index fcb9330..ff94cfa 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -2437,6 +2437,36 @@ > <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>; > iommus = <&apps_smmu 0x0040 0x1>; > }; > + > + video-codec@aa00000 { This needs to be sorted by address. It doesn't come after 18800000 (the address of the node above). > + compatible = "qcom,sdm845-venus"; > + reg = <0x0aa00000 0xff000>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;