Le mar. 25 juin 2019 à 19:30, Paul Burton <paul.burton@xxxxxxxx> a
écrit :
Hi Paul,
On Tue, Jun 25, 2019 at 12:57:50AM +0200, Paul Cercueil wrote:
+static const struct of_device_id ingenic_tcu_of_match[] = {
+ { .compatible = "ingenic,jz4740-tcu", .data = &jz4740_soc_info, },
+ { .compatible = "ingenic,jz4725b-tcu", .data = &jz4725b_soc_info,
},
+ { .compatible = "ingenic,jz4770-tcu", .data = &jz4740_soc_info, },
+ { }
+};
Nit: why not order these numerically? ie. 25b, 40, 70.
They are in chronological order - the jz4725b is newer than the jz4740.
+static struct regmap * __init ingenic_tcu_create_regmap(struct
device_node *np)
+{
+ struct resource res;
+ void __iomem *base;
+ struct regmap *map;
+
+ if (!of_match_node(ingenic_tcu_of_match, np))
+ return ERR_PTR(-EINVAL);
+
+ base = of_io_request_and_map(np, 0, "TCU");
+ if (IS_ERR(base))
+ return ERR_PTR(PTR_ERR(base));
This is equivalent to:
return ERR_CAST(base);
Alright - I'll fix it in a following patch if this V13 gets merged,
or in the V14 patchset.
Apart from those:
Reviewed-by: Paul Burton <paul.burton@xxxxxxxx>
Thanks,
Paul
