On Tue, Jun 25, 2019 at 12:34:56PM +0530, Vivek Gautam wrote: > On Mon, Jun 24, 2019 at 10:33 PM Will Deacon <will@xxxxxxxxxx> wrote: > > Instead, I think this needs to be part of a separate file that is maintained > > by you, which follows on from the work that Krishna is doing for nvidia > > built on top of Robin's prototype patches: > > > > http://linux-arm.org/git?p=linux-rm.git;a=shortlog;h=refs/heads/iommu/smmu-impl > > Looking at this branch quickly, it seem there can be separate implementation > level configuration file that can be added. > But will this also handle separate page table ops when required in future. Nothing's set in stone, but having the implementation-specific code constrain the page-table format (especially wrt quirks) sounds reasonable to me. I'm currently waiting for Krishna to respin the nvidia changes [1] on top of this so that we can see how well the abstractions are holding up. I certainly won't merge the stuff until we have a user. Will [1] https://lkml.kernel.org/r/1543887414-18209-1-git-send-email-vdumpa@xxxxxxxxxx