Hi Jeffrey, On Thu, Jun 20, 2019 at 7:33 AM Jeffrey Hugo <jeffrey.l.hugo@xxxxxxxxx> wrote: > #ifdef CONFIG_OF > -static const struct of_device_id elan_of_match[] = { > - { .compatible = "elan,ekth3000" }, > - { /* sentinel */ } > -}; I think OF IDs should stay in this file since we agreed HID will not be checking them. > MODULE_DEVICE_TABLE(of, elan_of_match); > #endif > > diff --git a/include/linux/input/elan-i2c-ids.h b/include/linux/input/elan-i2c-ids.h > new file mode 100644 > index 000000000000..8130bbebbdda > --- /dev/null > +++ b/include/linux/input/elan-i2c-ids.h > @@ -0,0 +1,68 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Elan I2C Touchpad devide whitelist s/devide/device/ > + * > + * Copyright (C) 2019 Jeffrey Hugo. All rights reserved. This just moves the code around. If anything I'd say it should keep the original Elan copyright. Thanks. -- Dmitry