Hi Fabrizio, Thank you for the patch. On Tue, Jun 18, 2019 at 04:18:38PM +0100, Fabrizio Castro wrote: > Add the HDMI encoder to the R8A774A1 DT in disabled state. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > --- > This patch depends on: > https://patchwork.kernel.org/patch/10995149/ Is that the correct one ? I don't see how CAN support is related. In any case, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 32 +++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > index d6dd4b6..a849ca7 100644 > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi > @@ -2397,6 +2397,37 @@ > }; > }; > > + hdmi0: hdmi@fead0000 { > + compatible = "renesas,r8a774a1-hdmi", > + "renesas,rcar-gen3-hdmi"; > + reg = <0 0xfead0000 0 0x10000>; > + interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 729>, > + <&cpg CPG_CORE R8A774A1_CLK_HDMI>; > + clock-names = "iahb", "isfr"; > + power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>; > + resets = <&cpg 729>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + dw_hdmi0_in: endpoint { > + remote-endpoint = <&du_out_hdmi0>; > + }; > + }; > + port@1 { > + reg = <1>; > + }; > + port@2 { > + /* HDMI sound */ > + reg = <2>; > + }; > + }; > + }; > + > du: display@feb00000 { > compatible = "renesas,du-r8a774a1"; > reg = <0 0xfeb00000 0 0x70000>; > @@ -2423,6 +2454,7 @@ > port@1 { > reg = <1>; > du_out_hdmi0: endpoint { > + remote-endpoint = <&dw_hdmi0_in>; > }; > }; > port@2 { -- Regards, Laurent Pinchart