On Wed, 19 Jun 2019 at 12:01, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> wrote: > > Hi Krzysztof, > > On 2019-06-18 21:05, Krzysztof Kozlowski wrote: > > Add vendor compatibles for specific implementation of Mali Utgard > > (Exynos3250, Exynos4-family) and Midgard (Exynos5433, Exynos7). > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 + > > Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > > index e5ad3b2afe17..9b298edec5b2 100644 > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt > > @@ -17,6 +17,7 @@ Required properties: > > * which must be preceded by one of the following vendor specifics: > > + "allwinner,sun50i-h6-mali" > > + "amlogic,meson-gxm-mali" > > + + "samsung,exynos5433-mali" > > + "rockchip,rk3288-mali" > > + "rockchip,rk3399-mali" > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > > index ae63f09fda7d..519018cb860b 100644 > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt > > @@ -17,6 +17,7 @@ Required properties: > > + amlogic,meson8b-mali > > + amlogic,meson-gxbb-mali > > + amlogic,meson-gxl-mali > > + + samsung,exynos3250-mali > I would prefer 'samsung,exynos4-mali', because historically Exynos4 was > the first SoC with Mali400 and such prefix is already used for many hw > blocks. Then maybe samsung,exynos4210-mali so it will not be confused with Exynos4415? Best regards, Krzysztof