On Tue, 2019-06-18 at 13:26 +0530, Yash Shah wrote: > On FU540, the management IP block is tightly coupled with the Cadence > MACB IP block. It manages many of the boundary signals from the MACB > IP > This patchset controls the tx_clk input signal to the MACB IP. It > switches between the local TX clock (125MHz) and PHY TX clocks. This > is necessary to toggle between 1Gb and 100/10Mb speeds. > > Future patches may add support for monitoring or controlling other IP > boundary signals. > > This patchset is mostly based on work done by > Wesley Terpstra <wesley@xxxxxxxxxx> > > This patchset is based on Linux v5.2-rc1 and tested on HiFive > Unleashed > board with additional board related patches needed for testing can be > found at dev/yashs/ethernet_v3 branch of: > https://github.com/yashshah7/riscv-linux.git > > Change History: > V3: > - Revert "MACB_SIFIVE_FU540" config changes in Kconfig and driver > code. > The driver does not depend on SiFive GPIO driver. > > V2: > - Change compatible string from "cdns,fu540-macb" to "sifive,fu540- > macb" > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb > driver. This is needed because on FU540, the macb driver depends on > SiFive GPIO driver. > - Avoid writing the result of a comparison to a register. > - Fix the issue of probe fail on reloading the module reported by: > Andreas Schwab <schwab@xxxxxxx> > > Yash Shah (2): > macb: bindings doc: add sifive fu540-c000 binding > macb: Add support for SiFive FU540-C000 > > Documentation/devicetree/bindings/net/macb.txt | 3 + > drivers/net/ethernet/cadence/macb_main.c | 123 > +++++++++++++++++++++++++ > 2 files changed, 126 insertions(+) > Can you also post the ethernet dt entry[1] along with this patch ? I think it would be good to all the dt related stuff reviewed together. [1] https://github.com/yashshah7/riscv-linux/commit/6d3af64bc5efed3915d658dc3bfe82dc1dbfafb3 I am able to get networking up in latest kernel + your patches in OpenSBI + U-Boot(with updated compatible string) + Linux bootflow. Tested-by: Atish Patra <atish.patra@xxxxxxx> Regards, Atish
