On Fri, May 24, 2019 at 9:41 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> > + reg:
> > + maxItems: 1
> > + description: Ethernet MMIO address range
> > +
> > + queue-rx:
> > + $ref: '/schemas/types.yaml#/definitions/phandle-array'
> > + maxItems: 1
>
> This doesn't actually do what you think it is doing. A $ref plus
> additional constraints need to be under an 'allOf' list.
>
> > + description: phandle to the RX queue on the NPE
>
> But this is a phandle plus 1 cell, right?
>
> - allOf:
> - $ref: '/schemas/types.yaml#/definitions/phandle-array'
> - items:
> - items:
> - description: phandle to the RX queue on the NPE
> - description: whatever the cell contains
> enum: [ 1, 2, 3, 4 ] # any constraints you can put on the cell
>
> This implicitly says you have 1 of a phandle + 1 cell.
>
> I need to add this to example-schema.yaml...
I just can't get this right :(
I have this:
queue-rx:
- allOf:
- $ref: '/schemas/types.yaml#/definitions/phandle-array'
- items:
- items:
- description: phandle to the RX queue on the NPE
- description: index of the NPE engine RX queue to use
enum: [ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 ]
I get this from dt_binding_check:
CHKDT Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml
Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.yaml:
properties:queue-rx: [{'allOf': [{'$ref':
'/schemas/types.yaml#/definitions/phandle-array'}, {'items':
[{'items': [{'description': 'phandle to the RX queue on the NPE'},
{'description': 'index of the NPE engine RX queue to use', 'enum': [0,
1, 2, 3, 4, 5, 6, 7, 8, 9, 10]}]}]}]}] is not of type 'object',
'boolean'
make[3]: *** [../Documentation/devicetree/bindings/Makefile:12:
Documentation/devicetree/bindings/net/intel,ixp4xx-ethernet.example.dts]
Error 1
Hm .... I just can't figure out what this recursive parsing thingie means...
I tried to update the pip3 repo but no cigar.
Any hints?
Yours,
Linus Walleij
