Hi, Am 17.06.19 um 18:34 schrieb Manivannan Sadhasivam: > On Mon, Jun 17, 2019 at 05:30:15PM +0100, Mark Brown wrote: >> On Mon, Jun 17, 2019 at 09:20:10PM +0530, Manivannan Sadhasivam wrote: >> >>> +++ b/drivers/regulator/atc260x-regulator.c >>> @@ -0,0 +1,389 @@ >>> +// SPDX-License-Identifier: GPL-2.0+ >>> +/* >>> + * Regulator driver for ATC260x PMICs >> >> Please make the entire comment a C++ one so this looks more intentional. No, this is intentional and the official style requested by GregKH. He suggested I patch the SPDX documentation to make this clearer, but I did not find time for this yet (and am not the one making this rule). Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)