Hello!
On 06/17/2019 04:13 AM, Peter Chen wrote:
[...]
>>> Signed-off-by: Peter Chen <peter.chen@xxxxxxx>
>>> ---
>>> arch/arm/boot/dts/imx7ulp.dtsi | 28 ++++++++++++++++++++++++++++
>>> 1 file changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
>>> b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50f37c8..5115e47715c3
>>> 100644
>>> --- a/arch/arm/boot/dts/imx7ulp.dtsi
>>> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
>>> @@ -30,6 +30,7 @@
>>> serial1 = &lpuart5;
>>> serial2 = &lpuart6;
>>> serial3 = &lpuart7;
>>> + usbphy0 = &usbphy1;
>>
>> Is that really needed?
> Yes, since the driver code uses aligned id, and the controller number is from 0 at the code.
> I commented it here: [1]
Fair enough...
>> [...]
>>> @@ -133,6 +134,33 @@
>> [...]
>>> + usbphy1: usbphy@0x40350000 {
>>
>> Name it "usb-phy@40350000" please.
>>
>
> Would you please list binding doc for your suggestion?
The DT spec v0.2, section 2.2.2:
https://github.com/devicetree-org/devicetree-specification/releases/download/v0.2/devicetree-specification-v0.2.pdf
>
> Thanks,
> Peter
>
> [1] https://patchwork.kernel.org/patch/10920599/
MBR, Sergei
