Re: [PATCH] arm64: dts: ti: k3-am65: Add MSMC RAM ranges in interconnect node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/17/19 9:54 AM, Tero Kristo wrote:
> On 30/05/2019 13:49, Nishanth Menon wrote:
>> On 16:13-20190529, Suman Anna wrote:
>>> From: Roger Quadros <rogerq@xxxxxx>
>>>
>>> Add the MSCM RAM address space to the ranges property of the cbass_main
>>> interconnect node so that the addresses can be translated properly.
>>>
>>> This fixes the probe failure in the sram driver for the MSMC RAM node.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@xxxxxx>
>>> Signed-off-by: Suman Anna <s-anna@xxxxxx>
>>> ---
>>>
>>> The following error message is seen without this:
>>> [    0.480261] sram interconnect@100000:sram@70000000: found no
>>> memory resource
>>> [    0.487497] sram: probe of interconnect@100000:sram@70000000
>>> failed with error -22
>>>
>>> regards
>>> Suman
>>>
>>>   arch/arm64/boot/dts/ti/k3-am65.dtsi | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>> b/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>> index 50f4be2047a9..68b3f954f1d1 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am65.dtsi
>>> @@ -68,6 +68,7 @@
>>>                <0x00 0x00900000 0x00 0x00900000 0x00 0x00012000>, /*
>>> serdes */
>>>                <0x00 0x01000000 0x00 0x01000000 0x00 0x0af02400>, /*
>>> Most peripherals */
>>>                <0x00 0x30800000 0x00 0x30800000 0x00 0x0bc00000>, /*
>>> MAIN NAVSS */
>>> +             <0x00 0x70000000 0x00 0x70000000 0x00 0x00200000>, /*
>>> MSMC SRAM */
>>>                /* MCUSS Range */
>>>                <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>,
>>>                <0x00 0x40200000 0x00 0x40200000 0x00 0x00900100>,
>>> -- 
>>> 2.21.0
>>>
>>
>> Arrgh.. Nice catch. Thanks. We should consider pulling this in as part
>> of early rc fixes please.
>>
>> Acked-by: Nishanth Menon <nm@xxxxxx>
> 
> Hmm, what is the failure this causes, except the probe message? SRAM
> driver obviously won't work but is it used for anything at the moment
> anyways?
> 
> I would rather queue this towards 5.3.

OK, I am fine either way.

regards
Suman



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux