Re: [PATCH v4 05/10] memory: tegra20-emc: Replace clk_get_sys with devm_clk_get

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



17.06.2019 12:46, Thierry Reding пишет:
> On Mon, Jun 17, 2019 at 02:35:46AM +0300, Dmitry Osipenko wrote:
>> There is no problem for drivers to request pll_m and pll_p clocks for
>> the device, hence there is no need to use clk_get_sys() and it could be
>> replaced with devm_clk_get() for consistency.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>> ---
>>  drivers/memory/tegra/tegra20-emc.c | 12 ++++--------
>>  1 file changed, 4 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
>> index 43aef3614b65..527aa4b90e95 100644
>> --- a/drivers/memory/tegra/tegra20-emc.c
>> +++ b/drivers/memory/tegra/tegra20-emc.c
>> @@ -527,33 +527,29 @@ static int tegra_emc_probe(struct platform_device *pdev)
>>  		goto unset_cb;
>>  	}
>>  
>> -	emc->pll_m = clk_get_sys(NULL, "pll_m");
>> +	emc->pll_m = devm_clk_get(&pdev->dev, "pll_m");
> 
> Interesting... I didn't know that clk_get() had a fallback path to
> return clk_get_sys() if the named clock wasn't found in DT. That's
> nice.
> 
> Looks good to me.

Yes, I didn't know either until recently. Thanks!



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux