On 13-Jun-19 9:12 PM, Thierry Reding wrote: > On Thu, Jun 13, 2019 at 03:39:46PM +0100, Lorenzo Pieralisi wrote: >> On Mon, Jun 10, 2019 at 10:08:16AM +0530, Manikanta Maddireddy wrote: >>> >>> On 04-Jun-19 7:40 PM, Manikanta Maddireddy wrote: >>>> On 04-Jun-19 6:44 PM, Thierry Reding wrote: >>>>> On Thu, May 16, 2019 at 11:23:01AM +0530, Manikanta Maddireddy wrote: >>>>>> Few endpoints like Wi-Fi supports power on/off and to leverage that >>>>>> root port must support hot-plug and hot-unplug. Tegra PCIe doesn't >>>>>> support hot-plug and hot-unplug, however it supports endpoint power >>>>>> on/off feature as follows, >>>>>> - Power off sequence: >>>>>> - Transition of PCIe link to L2 >>>>>> - Power off endpoint >>>>>> - Leave root port in power up state with the link in L2 >>>>>> - Power on sequence: >>>>>> - Power on endpoint >>>>>> - Apply hot reset to get PCIe link up >>>>>> >>>>>> PCIe client driver stops accessing PCIe endpoint config and BAR registers >>>>>> after endpoint is powered off. However, software applications like x11 >>>>>> server or lspci can access endpoint config registers in which case >>>>>> host controller raises "response decoding" errors. To avoid this scenario, >>>>>> add PCIe link up check in config read and write callback functions before >>>>>> accessing endpoint config registers. >>>>>> >>>>>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx> >>>>>> --- >>>>>> V4: No change >>>>>> >>>>>> V3: Update the commit log with explanation for the need of this patch >>>>>> >>>>>> V2: Change tegra_pcie_link_status() to tegra_pcie_link_up() >>>>>> >>>>>> drivers/pci/controller/pci-tegra.c | 38 ++++++++++++++++++++++++++++++ >>>>>> 1 file changed, 38 insertions(+) >>>>> This still doesn't look right to me conceptually. If somebody wants to >>>>> access the PCI devices after the kernel has powered them off, why can't >>>>> we just power the devices back on so that we allow userspace to properly >>>>> access the devices? >>>> 1. WiFi devices provides power-off feature for power saving in mobiles. >>>> When WiFi is turned off we shouldn't power on the HW back without user >>>> turning it back on. >>>> 2. When ever user process tries to access config space, it'll end up >>>> in these functions. We cannot have is_powered_on check in config read/write >>>> callbacks. >>>> 3. WiFi power on/off is device specific feature, we shouldn't handle it >>>> in PCI subsystem or host controller driver. >>>> >>>>> Or if that's not what we want, shouldn't we add something to the core >>>>> PCI infrastructure to let us deal with this? It seems like this is some >>>>> general problem that would apply to every PCI device and host bridge >>>>> driver. Having each driver implement this logic separately doesn't seem >>>>> like a good idea to me. >>>>> >>>>> Thierry >>>> This should be handled by hotplug feature, whenever endpoint is powered-off/ >>>> removed from the slot, hot unplug event should take care of it. Unfortunately >>>> Tegra PCIe doesn't support hotplug feature. >>>> >>>> Manikanta >>> Hi Bjorn, >>> >>> I thought about your comment in >>> https://patchwork.ozlabs.org/patch/1084204/ again. What if I add link >>> up check in tegra_pcie_isr() and make "response decoding error" as >>> debug print? EP Config access will happen when link is down, but >>> "Response decoding error" print comes only if debug log is enabled. >>> This way we can avoid race issue in config accessors and we get prints >>> when debug logs are enabled. >> I still do not see what you are actually solving. This patch should >> be dropped. > The problem that Manikanta is trying to solve here occurs in this > situation (Manikanta, correct me if I've got this wrong): on some > setups, a WiFi module connected over PCI will toggle a power GPIO as > part of runtime suspend. This effectively causes the module to disappear > from the PCI bus (i.e. it can no longer be accessed until the power GPIO > is toggled again). GPIO is toggled as part of WiFi on/off, can be triggered from network manager UI. > > This is fine from a kernel point of view because the kernel keeps track > of what devices are suspended. However, userspace will occasionally try > to read the configuration space access of all devices, and since it > doesn't have any knowledge about the suspend state of these devices, it > doesn't know which ones to leave alone. I think this happens when the > X.Org server is running. This is fine from a kernel point of view because PCI client driver doesn't initiate any PCIe transaction until network interface is up during WiFi on. > > One thing that Manikanta and I had discussed was that perhaps the device > should be hot-unplugged when it goes into this low-power state. However, > we don't support hotplug on Tegra210 where this is needed, so we'd need > some sort of software-induced hot-unplug. However, this low power state > is entered when the WiFi interface is taken down (i.e. ip link set dev > <interface> down). If we were to remove the PCI device in that case, it > means that the interface goes away completely, which is completely > unexpected from a user's perspective. After all, taking a link down and > up may be something that scripts are doing all the time. They'd fall > over if after taking the interface down, the interface completely > disappears. > > It's also not entirely clear to me how we get the device back onto the > bus again after it is in low power. If we hot-unplug the device, then > the driver will be unbound. Presumably the driver is what's controlling > the power GPIO, so there won't be any entity that can be used to bring > the chip back to life. Unless we deal with that power GPIO elsewhere > (rfkill switch perhaps?). Correct, rfkill switch should handle the GPIO. Sequence will be, - WiFi ON - rfkill switch enables the WiFi GPIO - Tegra PCIe receives hot plug event - Tegra PCIe hot plug driver rescans PCI bus and enumerates the device - PCI client driver is probed, which will create network interface - WiFi OFF - rfkill switch disables the WiFi GPIO - Tegra PCIe receives hot unplug event - Tegra PCIe hot plug driver removes PCI devices under the bus - PCI client driver remove is executed, which will remove network interface We don't need current patch in this case because PCI device is not present in the PCI hierarchy, so there cannot be EP config access with link down. However Tegra doesn't support hot plug and unplug events. I am not sure if we have any software based hot plug event trigger. I will drop current patch and pursue if above sequence can be implemented for Tegra. Manikanta > > Perhaps one other way to deal with this would be to track the suspend > state of devices and then have the code that implements the PCI access > from userspace refuse accesses to devices that are asleep. I suppose > this is somewhat of an odd use-case because traditionally I guess PCI > devices never power down to a state where their configuration space can > no longer be accessed. At least that's what would explain why this has > never been an issue before. Or perhaps it has? > > The last resort would be to just never put the WiFi chip into that low > power mode, though I'm not exactly sure what that means for the power > consumption on the affected systems. > > Manikanta, can you fill in some of the blanks above? > > Thierry >>> Thierry, >>> Please share your inputs as well. >>> >>> Manikanta >>> >>> >>>>>> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c >>>>>> index d20c88a79e00..33f4dfab9e35 100644 >>>>>> --- a/drivers/pci/controller/pci-tegra.c >>>>>> +++ b/drivers/pci/controller/pci-tegra.c >>>>>> @@ -428,6 +428,14 @@ static inline u32 pads_readl(struct tegra_pcie *pcie, unsigned long offset) >>>>>> return readl(pcie->pads + offset); >>>>>> } >>>>>> >>>>>> +static bool tegra_pcie_link_up(struct tegra_pcie_port *port) >>>>>> +{ >>>>>> + u32 value; >>>>>> + >>>>>> + value = readl(port->base + RP_LINK_CONTROL_STATUS); >>>>>> + return !!(value & RP_LINK_CONTROL_STATUS_DL_LINK_ACTIVE); >>>>>> +} >>>>>> + >>>>>> /* >>>>>> * The configuration space mapping on Tegra is somewhat similar to the ECAM >>>>>> * defined by PCIe. However it deviates a bit in how the 4 bits for extended >>>>>> @@ -493,20 +501,50 @@ static void __iomem *tegra_pcie_map_bus(struct pci_bus *bus, >>>>>> static int tegra_pcie_config_read(struct pci_bus *bus, unsigned int devfn, >>>>>> int where, int size, u32 *value) >>>>>> { >>>>>> + struct tegra_pcie *pcie = bus->sysdata; >>>>>> + struct pci_dev *bridge; >>>>>> + struct tegra_pcie_port *port; >>>>>> + >>>>>> if (bus->number == 0) >>>>>> return pci_generic_config_read32(bus, devfn, where, size, >>>>>> value); >>>>>> >>>>>> + bridge = pcie_find_root_port(bus->self); >>>>>> + >>>>>> + list_for_each_entry(port, &pcie->ports, list) >>>>>> + if (port->index + 1 == PCI_SLOT(bridge->devfn)) >>>>>> + break; >>>>>> + >>>>>> + /* If there is no link, then there is no device */ >>>>>> + if (!tegra_pcie_link_up(port)) { >>>>>> + *value = 0xffffffff; >>>>>> + return PCIBIOS_DEVICE_NOT_FOUND; >>>>>> + } >>>>>> + >>>>>> return pci_generic_config_read(bus, devfn, where, size, value); >>>>>> } >>>>>> >>>>>> static int tegra_pcie_config_write(struct pci_bus *bus, unsigned int devfn, >>>>>> int where, int size, u32 value) >>>>>> { >>>>>> + struct tegra_pcie *pcie = bus->sysdata; >>>>>> + struct tegra_pcie_port *port; >>>>>> + struct pci_dev *bridge; >>>>>> + >>>>>> if (bus->number == 0) >>>>>> return pci_generic_config_write32(bus, devfn, where, size, >>>>>> value); >>>>>> >>>>>> + bridge = pcie_find_root_port(bus->self); >>>>>> + >>>>>> + list_for_each_entry(port, &pcie->ports, list) >>>>>> + if (port->index + 1 == PCI_SLOT(bridge->devfn)) >>>>>> + break; >>>>>> + >>>>>> + /* If there is no link, then there is no device */ >>>>>> + if (!tegra_pcie_link_up(port)) >>>>>> + return PCIBIOS_DEVICE_NOT_FOUND; >>>>>> + >>>>>> return pci_generic_config_write(bus, devfn, where, size, value); >>>>>> } >>>>>> >>>>>> -- >>>>>> 2.17.1 >>>>>>
