Quoting Jarkko Sakkinen (2019-06-14 08:27:00) > On Thu, Jun 13, 2019 at 11:09:24AM -0700, Stephen Boyd wrote: > > diff --git a/include/linux/tpm.h b/include/linux/tpm.h > > index 1b5436b213a2..48df005228d0 100644 > > --- a/include/linux/tpm.h > > +++ b/include/linux/tpm.h > > @@ -132,6 +132,8 @@ struct tpm_chip { > > int dev_num; /* /dev/tpm# */ > > unsigned long is_open; /* only one allowed */ > > > > + unsigned long is_suspended; > > + > > char hwrng_name[64]; > > struct hwrng hwrng; > > I think it would better idea to have a bitmask of some sort that > would have bits for 'open' and 'suspended'. > Sure. I can combine is_open and is_suspended into some sort of 'unsigned long flags' member and then have #define TPM_IS_OPEN 0 and #define TPM_IS_SUSPENDED 1 defines?