On Fri, Jun 14, 2019 at 4:32 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > On Fri, Jun 14, 2019 at 6:56 PM Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > On Fri, Jun 14, 2019 at 9:05 AM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > > > > > On Fri, Jun 14, 2019 at 11:19 AM Chen-Yu Tsai <wens@xxxxxxxx> wrote: > > > > > > > > On Fri, Jun 14, 2019 at 2:53 AM Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > > > > > TCON LCD0, LCD1 in allwinner R40, are used for managing > > > > > LCD interfaces like RGB, LVDS and DSI. > > > > > > > > > > Like TCON TV0, TV1 these LCD0, LCD1 are also managed via > > > > > tcon top. > > > > > > > > > > Add support for it, in tcon driver. > > > > > > > > > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > > > > > > > Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx> > > > > > > I take that back. > > > > > > The TCON output muxing (which selects whether TCON LCD or TCON TV > > > outputs to the GPIO pins) > > > is not supported yet. Please at least add TODO notes, or ideally, > > > > Are you referring about port selection? it is support in > > sun8i_tcon_top_de_config. > > No. That's supported as you already pointed out. That only selects > which mixer outputs to which TCON. > > I'm talking about the GPIOD and GPIOH bits, which select which of > LCD or TV TCON outputs to the LCD function pins. Keep in mind that > the TV TCON's H/V SYNC signals are used in combination with the > TV encoder RGB outputs for VGA. Got it, so do I need to add TODO on sun8i_r40_lcd_quirks struct?
