On 07/06/2019 22:27, Martin Blumenstingl wrote: > Hi Krzysztof, > > On Thu, Jun 6, 2019 at 3:24 PM Krzysztof Michonski > <michonskikrzysztof@xxxxxxxxx> wrote: > [...] >> +struct meson_sm_chip gxl_chip = { >> + .shmem_size = SZ_4K, >> + .cmd_shmem_in_base = 0x82000023, >> + .cmd_shmem_out_base = 0x82000024, > where did you get these values from and/or what issues did you see > with the values from GXBB? > > I checked Amlogic's buildroot kernel whether they are doing something similar: > $ grep in_base_func > buildroot-openlinux-A113-201901/kernel/aml-4.9/arch/arm64/boot/dts/amlogic/mesong*.dtsi > | cut -d':' -f2 | sort -u > in_base_func = <0x82000020>; > that includes GXL, GXM, G12A and G12B. however, I admit that I didn't > have time to test your patch yet (so it may be just fine and the > vendor kernel is buggy) Same question from me, we've been using the same shmem address on GXL for years now without any issues, can you elaborate ? Neil > > > Martin > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-amlogic >