On Tue, Jun 11, 2019 at 06:49:08PM +0100, Thomas Preston wrote: > Add a device attribute to control the enable regulator. Write 1 to > enable, 0 to disable (ref-count minus one), or -1 to force disable the > physical pin. > To disable a set of amplifiers wired to the same enable gpio, each > device must be disabled. For example: > echo 0 > /sys/devices/.../device:00/enable > echo 0 > /sys/devices/.../device:01/enable This is adding a new ABI completely outstide the standard ALSA and power management frameworks and ABIs with no explanation as to why or integration with the rest of the driver. This is obviously not in the slightest bit OK. If there's something missing from the frameworks extend the frameworks, don't just ignore them.
Attachment:
signature.asc
Description: PGP signature
