Re: [PATCH 1/5] dt-bindings: vendor: Escape single quote

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Jun 11, 2019 at 03:18:51PM -0600, Rob Herring wrote:
> On Sat, May 25, 2019 at 7:41 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
> >
> > Single quotes need to be escaped in YAML, make sure it's the case.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 19cc3240a445..ec53162e900d 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -672,7 +672,7 @@ patternProperties:
> >    "^plantower,.*":
> >      description: Plantower Co., Ltd
> >    "^plathome,.*":
> > -    description: Plat'Home Co., Ltd.
> > +    description: Plat\'Home Co., Ltd.
>
> Actually, I think this isn't necessary. Where was this causing a
> problem? Only in single quoted strings do you have to escape a single
> quote and it is done with 2 single quotes rather than a backslash.

I guess I misread the YAML spec though... Sorry.

> However, to maintain a json compatible subset of yaml, maybe we do
> need it.

If you don't want it anymore, I guess we can drop or revert it.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux