On 12/06/2019 13:44, Sameer Pujar wrote: > > On 6/12/2019 6:07 PM, Jon Hunter wrote: >> >> On 11/06/2019 09:56, Sameer Pujar wrote: >>> Enable ACONNECT, ADMA and AGIC devices for following platforms >>> * Jetson TX2 >>> * Jetson Xavier >>> >>> Verified driver probe path and devices get registered fine. >>> >>> Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 12 ++++++++++++ >>> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 12 ++++++++++++ >>> 2 files changed, 24 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts >>> b/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts >>> index 5102de1..b818355 100644 >>> --- a/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts >>> +++ b/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts >>> @@ -298,4 +298,16 @@ >>> vin-supply = <&vdd_5v0_sys>; >>> }; >>> }; >>> + >>> + aconnect@2a41000 { >>> + status = "okay"; >>> + >>> + dma-controller@2930000 { >>> + status = "okay"; >>> + }; >>> + >>> + agic@2a41000 { >>> + status = "okay"; >>> + }; >>> + }; >>> }; >>> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >>> b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >>> index 6e6df65..d1cc028 100644 >>> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >>> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >>> @@ -167,4 +167,16 @@ >>> }; >>> }; >>> }; >>> + >>> + aconnect@2a41000 { >>> + status = "okay"; >>> + >>> + dma-controller@2930000 { >>> + status = "okay"; >>> + }; >>> + >>> + agic@2a41000 { >>> + status = "okay"; >>> + }; >>> + }; >>> }; >>> >> I believe that I have already ACK'ed this, so please include for the >> next revision. > There is a small change related to dma node. > Will include ACK in the next revision. OK. I had assumed there was no change. Ah the 'dma-controller' name! Usually you should list the changes for each revision under the '---' beneath the signed-off line so people can see if there are any changes. Cheers Jon -- nvpublic