RE: [PATCH] arm64: dts: renesas: hihope-common: Add uSD and eMMC

[Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>]

Hello Geert,

Thank you for your feedback!

> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 12 June 2019 09:28
> Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add uSD and eMMC
> 
> Hi Fabrizio,
> 
> On Fri, Jun 7, 2019 at 10:14 AM Fabrizio Castro
> <fabrizio.castro@xxxxxxxxxxxxxx> wrote:
> > This patch adds uSD and eMMC support to the HiHope RZ/G2M
> > board.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> 
> > +&sdhi3 {
> > +       pinctrl-0 = <&sdhi3_pins>;
> > +       pinctrl-1 = <&sdhi3_pins>;
> > +       pinctrl-names = "default", "state_uhs";
> > +
> > +       vmmc-supply = <&reg_3p3v>;
> > +       vqmmc-supply = <&reg_1p8v>;
> > +       bus-width = <8>;
> > +       mmc-hs200-1_8v;
> 
> Does the eMMC support HS400, too?

The eMMC does support HS400, but if I list it here the eMMC won't work properly as the SoC can't deal with it.
Wolfram's patch blacklists HS400 for the RZ/G2M (revisions "ES1.[012]"):
https://www.mail-archive.com/linux-renesas-soc@xxxxxxxxxxxxxxx/msg40630.html
I was thinking about sending a follow-up patch to list hs400 here after Wolfram's patch appears in a RC, would
that be okay with you?

Thanks,
Fab

> 
> > +       non-removable;
> > +       fixed-emmc-driver-type = <1>;
> > +       status = "okay";
> > +};
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds