Hi Anson, On Tue, Jun 11, 2019 at 3:31 AM <Anson.Huang@xxxxxxx> wrote: > > From: Anson Huang <Anson.Huang@xxxxxxx> > > i.MX system controller RTC driver can support all i.MX SoCs > with system controller inside, this patch makes the compatible > string more generic to support other i.MX SoCs with system > controller inside, such as i.MX8QM etc.. > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > --- > drivers/rtc/rtc-imx-sc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-imx-sc.c b/drivers/rtc/rtc-imx-sc.c > index c933045..38ef3ca 100644 > --- a/drivers/rtc/rtc-imx-sc.c > +++ b/drivers/rtc/rtc-imx-sc.c > @@ -178,7 +178,7 @@ static int imx_sc_rtc_probe(struct platform_device *pdev) > } > > static const struct of_device_id imx_sc_dt_ids[] = { > - { .compatible = "fsl,imx8qxp-sc-rtc", }, > + { .compatible = "fsl,imx-sc-rtc", }, What is wrong with the current compatible string? If you want to support i.MX8QM just add in its dtsi: compatible = "fsl,imx8qm-sc-rtc", "fsl,imx8qxp-sc-rtc" and add a dt-bindings entry for "fsl,imx8qm-sc-rtc"