On 11/06/2019 11:45, Jonathan Cameron wrote: >> + pci_disable_pasid(pdev); >> + master->ssid_bits = 0; > > If we are being really fussy about ordering, why have this set of > ssid_bits after pci_disable_pasid rather than before (to reverse order > of .._enable_pasid)? Sure, I'll change that Thanks, Jean