> + struct gpio_desc *reset_gpio; > + > if (data->reset_gpio < 0) { > struct device_node *np = priv->device->of_node; > > - data->reset_gpio = of_get_named_gpio(np, > - "snps,reset-gpio", 0); > - if (data->reset_gpio < 0) > - return 0; > + reset_gpio = devm_gpiod_get_optional(priv->device, > + "snps,reset", > + GPIOD_OUT_LOW); > + if (IS_ERR(reset_gpio)) > + return PTR_ERR(reset_gpio); > > - data->active_low = of_property_read_bool(np, > - "snps,reset-active-low"); Hi Martin I think you need to keep this here. You can then use it to decide how to change gpio_desc to remove flags that should be ignored. Andrew