On Mon, Jun 3, 2019 at 9:35 AM Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:
> Add drive strength support for Bitmain BM1880 SoC.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Patch applied, no point in holding this back about nitpicking.
Follow up if you want to change the below:
> +static int bm1880_pinconf_drv_set(unsigned int mA, u32 width,
> + u32 *regval, u32 bit_offset)
> +{
> + u32 _regval;
> +
> + _regval = *regval;
(... lots of fun with _reqval ...)
> + *regval = _regval;
> +
> + return 0;
I would avoid using any _names and __names because of ambiguity
(no clear semantic meaning) I would just call the variable in the
function *regp and the _regval just "reg" but it's just me.
Yours,
Linus Walleij
