Quoting Vinod Koul (2019-06-07 03:12:34) > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > new file mode 100644 > index 000000000000..1cbc884444c9 > --- /dev/null > +++ b/drivers/clk/qcom/gcc-sm8150.c > +static const struct parent_map gcc_parent_map_0[] = { > + { P_BI_TCXO, 0 }, > + { P_GPLL0_OUT_MAIN, 1 }, > + { P_GPLL0_OUT_EVEN, 6 }, > + { P_CORE_BI_PLL_TEST_SE, 7 }, > +}; > + > +static const char * const gcc_parent_names_0[] = { We have a new way of specifying clk parents now. Can you use that instead of using strings everywhere? > + "bi_tcxo", > + "gpll0", > + "gpll0_out_even", > + "core_bi_pll_test_se",