Hi Krzysztof, the subject should start with: "arm64: dts: meson-gxl:", see the git history (note that there was a rule change to use "arm64" instead of "ARM64") On Thu, Jun 6, 2019 at 3:24 PM Krzysztof Michonski <michonskikrzysztof@xxxxxxxxx> wrote: > > From: Krzysztof Michonski <michonskikrzysztof@xxxxxxxxx> > > Add secure monitor node in the gxl dtsi file. I assume that this is to enable the GXL and GXM specific commands? > Signed-off-by: Krzysztof Michonski <michonskikrzysztof@xxxxxxxxx> > --- > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > index 3093ae421b17..fd75538ee9f9 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > @@ -37,6 +37,10 @@ > }; > }; > }; > + > + sm: secure-monitor { > + compatible = "amlogic,meson-gxl-sm"; > + }; > }; if you keep the secure-monitor node in meson-gx.dtsi then you can use something like: &sm { compatible = "amlogic,meson-gxl-sm"; }; the compatible string has to be added to the documentation in Documentation/devicetree/bindings/firmware/meson/meson_sm.txt with a separate patch devicetree bindings should be backwards compatible (at least that's the rule of thumb) you can use a fallback compatible string so this new .dts/.dtb also works with old kernels (which don't support the new, GXL specific, compatible string yet): compatible = "amlogic,meson-gxl-sm", "amlogic,meson-gxbb-sm"; Martin