> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Thursday 6 June 2019 14:26 > To: Dragan Cvetic <draganc@xxxxxxxxxx> > Cc: arnd@xxxxxxxx; Michal Simek <michals@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; > mark.rutland@xxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Derek Kiernan <dkiernan@xxxxxxxxxx> > Subject: Re: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl > > On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote: > > Add char device interface per DT node present and support > > file operations: > > - open(), > > - close(), > > - unlocked_ioctl(), > > - compat_ioctl(). > > > > Tested-by: Dragan Cvetic <dragan.cvetic@xxxxxxxxxx> > > Signed-off-by: Derek Kiernan <derek.kiernan@xxxxxxxxxx> > > Signed-off-by: Dragan Cvetic <dragan.cvetic@xxxxxxxxxx> > > --- > > drivers/misc/xilinx_sdfec.c | 57 +++++++++++++++++++++++++++++++++++++--- > > include/uapi/misc/xilinx_sdfec.h | 4 +++ > > 2 files changed, 58 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/misc/xilinx_sdfec.c b/drivers/misc/xilinx_sdfec.c > > index ff32d29..740b487 100644 > > --- a/drivers/misc/xilinx_sdfec.c > > +++ b/drivers/misc/xilinx_sdfec.c > > @@ -51,7 +51,6 @@ struct xsdfec_clks { > > * @regs: device physical base address > > * @dev: pointer to device struct > > * @config: Configuration of the SDFEC device > > - * @open_count: Count of char device being opened > > Why is this removed here? You don't add something in one patch and then > remove it in a later one if it's never needed :) Accepted. Will be removed from previous patches. > > thanks, > > greg k-h
