On 06.06.2019 20:22, Stephen Boyd wrote: > Quoting Leonard Crestez (2019-06-06 10:15:32) >> On 06.06.2019 19:55, Stephen Boyd wrote: >>> Quoting Fabio Estevam (2019-06-06 09:44:43) >>>> Use devm_platform_ioremap_resource() to simplify the code a bit. >>>> >>>> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx> >>>> --- >>> >>> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxx> >> >> An extremely similar patch was already submitted and then reverted >> because it breaks boot: >> >> The current imx8 lpcg driver maps entire subsystems at once and if >> devm_platform_ioremap_resource is used then devices inside the subsystem >> will fail to probe, including lpuart! >> >> The hardware on imx8qxp and related parts (imx8qm) has multiple separate >> LPCG blocks interspersed between devices. Some refactoring patches were >> posted by Aisheng to split LPCG into multiple blocks but apparently got >> stuck in review: >> >> There were some disagreements regarding DT bindings for split imx8 >> clocks, what would it take to move those patches forward? > > Don't know. I'll have to read those patches on the list and reply there. Some specific advice on how to refactor and split imx8qxp clk in a way that is acceptable to upstream would be very helpful to us. -- Regards, Leonard
