On Thu, 2019-06-06 at 16:47 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2019-06-06 at 08:37 +0200, Greg KH wrote: > > On Thu, Jun 06, 2019 at 07:55:43AM +1000, Benjamin Herrenschmidt wrote: > > > On Wed, 2019-06-05 at 09:59 +0200, Greg KH wrote: > > > > > > > > > +struct irq_domain *al_fic_wire_get_domain(struct al_fic *fic); > > > > > + > > > > > +struct al_fic *al_fic_wire_init(struct device_node *node, > > > > > + void __iomem *base, > > > > > + const char *name, > > > > > + unsigned int parent_irq); > > > > > +int al_fic_cleanup(struct al_fic *fic); > > > > > > > > Who is using these new functions? We don't add new apis that no one > > > > uses :( > > > > > > They will be used by subsequent driver submissions but those aren't > > > quite ready yet, so we can hold onto patch 3 for now until they are. > > > > Patch 2 also should have these removed :) > > That's a mistake, that export should have been in patch3. Talel, pls > fix that in your next spin. Actually that's already fixed in v2 of the series. The API have been removed for now. Cheers, Ben.