Hi guys, On 31/05/2019 06:14, Borislav Petkov wrote: > On Fri, May 31, 2019 at 01:15:33AM +0000, Herrenschmidt, Benjamin wrote: >> This isn't terribly helpful, there's nothing telling anybody which of >> those files corresponds to an ARM SoC :-) > > drivers/edac/altera_edac.c is one example. > > Also, James and I have a small writeup on how an arm driver should look > like, we just need to polish it up and post it. > > James? Yes I should get on with that. Its mostly for platforms which end up with multiple piecemeal drivers and some co-ordination is needed. It doesn't look like that will be a problem here. >> That said ... >> >> You really want a single EDAC driver that contains all the stuff for >> the caches, the memory controller, etc... ? This has to be platform specific as it has integration-time dependencies and firmware dependencies. Doing it as a platform driver matched from the machine-compatible may be more straightforward today. The DT will already say "compatible = arm,cortex-a57" for the Alpine-v2, what that 'edac_l1_l2' node is telling us is the integration/firmware stuff has been done, and the imp-def instructions can be used. Thanks, James
