Hi Sean, On Fri, 2019-05-31 at 06:50 +0800, Sean Wang wrote: > Hi Neal, > > On Mon, May 27, 2019 at 1:39 AM Neal Liu <neal.liu@xxxxxxxxxxxx> wrote: > > > > 1. Add a header file to provide SIP interface to ARM Trusted > > Firmware(ATF) > > 2. Add hwrng SMC fid > > > > Signed-off-by: Neal Liu <neal.liu@xxxxxxxxxxxx> > > --- > > include/linux/soc/mediatek/mtk_sip_svc.h | 51 ++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h > > > > diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h > > new file mode 100644 > > index 0000000..f65d403 > > --- /dev/null > > +++ b/include/linux/soc/mediatek/mtk_sip_svc.h > > @@ -0,0 +1,51 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (c) 2019 MediaTek Inc. > > + */ > > + > > +#ifndef _MTK_SECURE_API_H_ > > +#define _MTK_SECURE_API_H_ > > + > > +#include <linux/kernel.h> > > + > > +/* Error Code */ > > +#define SIP_SVC_E_SUCCESS 0 > > +#define SIP_SVC_E_NOT_SUPPORTED -1 > > +#define SIP_SVC_E_INVALID_PARAMS -2 > > +#define SIP_SVC_E_INVALID_RANGE -3 > > +#define SIP_SVC_E_PERMISSION_DENY -4 > > + > > +#ifdef CONFIG_ARM64 > > +#define MTK_SIP_SMC_AARCH_BIT 0x40000000 > > #define MTK_SIP_SMC_AARCH_BIT BIT(30) > > > +#else > > +#define MTK_SIP_SMC_AARCH_BIT 0x00000000 > > #define MTK_SIP_SMC_AARCH_BIT 0 > > > +#endif > > + > > +/******************************************************************************* > > + * Defines for Mediatek runtime services func ids > > + ******************************************************************************/ > > It would be good if remove the trivial and below all unused comments. Okay, I'll keep the necessary parts, thanks > > > + > > +/* Debug feature and ATF related SMC call */ > > + > > +/* CPU operations related SMC call */ > > + > > +/* SPM related SMC call */ > > + > > +/* Low power related SMC call */ > > + > > +/* AMMS related SMC call */ > > + > > +/* Security related SMC call */ > > +/* HWRNG */ > > +#define MTK_SIP_KERNEL_GET_RND \ > > + (0x82000206 | MTK_SIP_SMC_AARCH_BIT) > > + > > +/* Storage Encryption related SMC call */ > > + > > +/* Platform related SMC call */ > > + > > +/* Pheripheral related SMC call */ > > + > > +/* MM related SMC call */ > > + > > +#endif /* _MTK_SECURE_API_H_ */ > > -- > > 1.7.9.5 > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-mediatek