Hi Richard, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Richard-Cochran/Peer-to-Peer-One-Step-time-stamping/20190531-213601 config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): drivers//ptp/ptp_ines.c: In function 'ines_txtstamp': >> drivers//ptp/ptp_ines.c:674:3: warning: 'old_skb' may be used uninitialized in this function [-Wmaybe-uninitialized] kfree_skb(old_skb); ^~~~~~~~~~~~~~~~~~ vim +/old_skb +674 drivers//ptp/ptp_ines.c 651 652 static void ines_txtstamp(struct mii_timestamper *mii_ts, 653 struct sk_buff *skb, int type) 654 { 655 struct ines_port *port = container_of(mii_ts, struct ines_port, mii_ts); 656 struct sk_buff *old_skb; 657 unsigned long flags; 658 659 if (!port->txts_enabled || ines_txts_onestep(port, skb, type)) { 660 kfree_skb(skb); 661 return; 662 } 663 664 spin_lock_irqsave(&port->lock, flags); 665 666 if (port->tx_skb) 667 old_skb = port->tx_skb; 668 669 port->tx_skb = skb; 670 671 spin_unlock_irqrestore(&port->lock, flags); 672 673 if (old_skb) > 674 kfree_skb(old_skb); 675 676 schedule_delayed_work(&port->ts_work, 1); 677 } 678 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
