From: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
Date: Mon, 27 May 2019 10:16:35 +0200
> +/* Calculate offsets for entry */
> +static void is2_data_get(struct vcap_data *data, int ix)
> +{
> + const struct vcap_props *vcap = &vcap_is2;
> + u32 i, col, offset, count, cnt, base, width = vcap->tg_width;
Reverse christmas tree please.
> +static void is2_entry_set(struct ocelot *ocelot, int ix,
> + struct ocelot_ace_rule *ace)
> +{
> + u32 val, msk, type, type_mask = 0xf, i, count;
> + struct ocelot_vcap_u64 payload = { 0 };
> + struct ocelot_ace_vlan *tag = &ace->vlan;
> + struct vcap_data data = { 0 };
> + int row = (ix / 2);
Likewise.
> +static void is2_entry_get(struct ocelot_ace_rule *rule, int ix)
> +{
> + struct vcap_data data;
> + struct ocelot *op = rule->port->ocelot;
> + int row = (ix / 2);
> + u32 cnt;
Likewise.
> +static void ocelot_ace_rule_add(struct ocelot_acl_block *block,
> + struct ocelot_ace_rule *rule)
> +{
> + struct list_head *pos, *n;
> + struct ocelot_ace_rule *tmp;
Likewise.
And so on and so forth for your entire submission.
Thank you.
