On Wed, May 22, 2019 at 03:42:20AM +0200, Andrew Lunn wrote: > I don't know about the PTP subsystem, but in general, forward > declarations are frowned upon, and it is generally requested to > reorder the functions to remove them. I am not aware of any general coding style rule or even defacto practice in this area, but there is a method to this driver. The functions are in alphabetical order. This makes it easier to find your way around the driver. Thanks, Richard