Re: [PATCH] dt-bindings: phy: mvebu-comphy: Update references to CP110 nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

Rob Herring <robh+dt@xxxxxxxxxx> wrote on Wed, 22 May 2019 08:15:27
-0500:

> On Tue, May 21, 2019 at 9:35 AM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> >
> > From: Grzegorz Jaszczyk <jaz@xxxxxxxxxxxx>
> >
> > The CP110 DT nodes references have changed, reflect these changes in
> > COMPHY documentation.  
> 
> This change isn't necessary. The examples are just examples. They
> don't have to match anything exactly.

Ok then, let's drop it.

> 
> >
> > Signed-off-by: Grzegorz Jaszczyk <jaz@xxxxxxxxxxxx>
> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/phy/phy-mvebu-comphy.txt          | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > index cf2cd86db267..af2402c18513 100644
> > --- a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > +++ b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > @@ -35,19 +35,19 @@ Required properties (child nodes):
> >
> >  Examples:
> >
> > -       cpm_comphy: phy@120000 {
> > +       CP110_LABEL(comphy): phy@120000 {  
> 
> Also, as we convert bindings to schema, the examples are compiled and
> this won't without CP110_LABEL defined.

I didn't thought about the YAML schema conversion issue (IIRC there are
already occurrences of such macro in the bindings).

Thanks,
Miquèl



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux