On Fri, May 24, 2019 at 02:13:59PM +0200, Torsten Duwe wrote: > On Thu, May 23, 2019 at 07:48:03AM -0700, Vasily Khoruzhick wrote: > > On Wed, May 22, 2019 at 11:54 PM Torsten Duwe <duwe@xxxxxx> wrote: > > > > > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts > > > @@ -65,6 +65,21 @@ > > > }; > > > }; > > > > > > + panel: panel { > > > + compatible ="innolux,n116bge", "simple-panel"; > > > > IIRC Rob wanted it to be edp-connector, not simple-panel. Also you > > need to introduce edp-connector binding. > > This line is identically found in > arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi and > arch/arm64/boot/dts/nvidia/tegra132-norrin.dts That's not really an argument though. These are using rather old bindings, and realising that they are flawed and fixing these flaws is a natural process. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature