Hi Alexandre, On Thu, May 23, 2019 at 05:05:51PM +0200, Alexandre Torgue wrote: > Hi Maxime > > On 5/23/19 11:56 AM, Maxime Ripard wrote: > > Switch the STMMAC / Synopsys DesignWare MAC controller binding to a YAML > > schema to enable the DT validation. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx> > > --- > > First, thanks a lot for this patch. Just one question: > We could add ranges for some properties in order to avoid "bad value" for a > property. If I understand correctly you do it only for snps,dwxgmac, > snps,dwxgmac-2.10 and st,spear600-gmac. Why not do it for all supported IPs > ? (Maybe it is something that we could add later) > We definitely can do that. It wasn't really obvious to me what the limits were by reading the previous documentation, but if you can provide them we can definitely add them. > > + snps,tso: > > + $ref: /schemas/types.yaml#definitions/flag > > + description: > > + Enables the TSO feature otherwise it will be managed by > > + MAC HW capability register. Only for GMAC4 and newer. > > TSO is also available for snps,dwmac-4.00 and snps,dwmac-4.10a Ack, I'll change it. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
