On Mon, May 20, 2019 at 02:46:11PM -0500, Rob Herring wrote: > On Mon, May 20, 2019 at 10:51 AM Maxime Ripard > <maxime.ripard@xxxxxxxxxxx> wrote: > > > > Hi Rob, > > > > I've noticed that you recently added support to validate the *-supply > > properties in the dt-schema tools. > > > > However, we have a family of PMIC that are exposing a bunch of power > > supplies (battery, AC, USB, etc) to know what is currently powering > > the board. > > > > All these various supplies are exposed as children nodes of the PMIC > > itself, and they are named *-power-supply. For an example, you can > > look at: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/axp209.dtsi#n56 > > > > Now, those are obviously not properties, and yet the current dt-schema > > schemas are trying to validate them. > > > > I'm not really sure how to fix that. Changing the node names seems > > like an obvious solution, but they seem to be what they should be. Can > > we reduce the scope of the validation to only match properties (ie > > arrays?) and not the nodes (objects?) > > While I'd prefer to avoid that node name, I fixed it with the fancy > new if/then schema: > > ".*-supply$": > if: > not: { type: object } > then: > $ref: "types.yaml#/definitions/phandle" > > I'll push it out shortly. Great, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
