On Mon, 13 May 2019 09:53:05 -0500
Adam Michaelis <adam.michaelis@xxxxxxxxxxxxxxxxxxx> wrote:
> The AD7949 has a feature to include the configuration register value
> used to generate the ADC sample. This feature is configurable, but do
> not see a good use case for it in the driver (neither did reviewing
> maintainers), so removing the supporting logic in order to simplify the
> driver.
>
> Signed-off-by: Adam Michaelis <adam.michaelis@xxxxxxxxxxxxxxxxxxx>
Excellent. For reference
Acked-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Waiting for Analog review on the whole series.
Thanks,
Jonathan
> ---
> V3:
> - First version of series with this patch. Maintainers agreed
> that this capability of the hardware is not useful and should
> be dropped from driver.
> ---
> drivers/iio/adc/ad7949.c | 22 ++--------------------
> 1 file changed, 2 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c
> index d67033a008e5..bac16a2f7850 100644
> --- a/drivers/iio/adc/ad7949.c
> +++ b/drivers/iio/adc/ad7949.c
> @@ -102,24 +102,6 @@ static void ad7949_set_bits_per_word(struct ad7949_adc_chip *ad7949_adc)
> ad7949_adc->bits_per_word = 8;
> }
>
> -static bool ad7949_spi_cfg_is_read_back(struct ad7949_adc_chip *ad7949_adc)
> -{
> - if (!(ad7949_adc->cfg & AD7949_CFG_READBACK))
> - return true;
> -
> - return false;
> -}
> -
> -static int ad7949_message_len(struct ad7949_adc_chip *ad7949_adc)
> -{
> - int tx_len = 2;
> -
> - if (ad7949_spi_cfg_is_read_back(ad7949_adc))
> - tx_len += 2;
> -
> - return tx_len;
> -}
> -
> static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val,
> u16 mask)
> {
> @@ -129,7 +111,7 @@ static int ad7949_spi_write_cfg(struct ad7949_adc_chip *ad7949_adc, u16 val,
> struct spi_transfer tx[] = {
> {
> .tx_buf = &ad7949_adc->buffer,
> - .len = ad7949_message_len(ad7949_adc),
> + .len = 2,
> .bits_per_word = ad7949_adc->bits_per_word,
> }
> };
> @@ -197,7 +179,7 @@ static int ad7949_spi_read_channel(struct ad7949_adc_chip *ad7949_adc, int *val,
> struct spi_transfer tx[] = {
> {
> .rx_buf = &ad7949_adc->buffer,
> - .len = ad7949_message_len(ad7949_adc),
> + .len = 2,
> .bits_per_word = ad7949_adc->bits_per_word,
> }
> };
