On Wed, Apr 24, 2019 at 4:25 AM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > > Add new backlight bindings for the TI LM3630A dual-string white LED. > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > --- > Changes since v5: > - Change 'lm3630a_bl@38' in examples to 'led-controller@38' > > Changes since v4: > - Drop $ref from led-sources > - Drop description from reg of i2c address > - Expand description of reg for the control bank > - Drop status from examples > > Changes since v3: > - Add label. I didn't add a description for it since that'll come from > the common properties once its converted. > > Changes since v2: > - Update description of max-brightness > - Add description for reg > - Correct typo: s/tranisiton/transition > - add reg to control banks > - add additionalProperties > > .../leds/backlight/lm3630a-backlight.yaml | 129 ++++++++++++++++++ > 1 file changed, 129 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml I'm working on getting the examples to be validated by the schema (in addition to just building with dtc) and there's a couple of errors: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: '#address-cells', '#size-cells' do not match any of the regexes: '^led@[01]$', 'pinctrl-[0-9]+' Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: '#address-cells', '#size-cells' do not match any of the regexes: '^led@[01]$', 'pinctrl-[0-9]+' You didn't list '#address-cells' and '#size-cells'. Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: led@0: 'ti,linear-mapping-mode' does not match any of the regexes: 'pinctrl-[0-9]+' Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: led@1: 'ti,linear-mapping-mode' does not match any of the regexes: 'pinctrl-[0-9]+' 'ti,linear-mapping-mode' is not defined in the child nodes. Rob
