On Wed, May 08, 2019 at 06:46:37AM +0000, Ran Wang wrote: > This patch adds USB dt nodes for LS1028A. > > Signed-off-by: Ran Wang <ran.wang_1@xxxxxxx> > --- > Changes in v3: > - Add space between label and node name. > - Add spcae with properties and '='. > - Add SoC specific compatible. > > Changes in v2: > - Rename node from usb3@... to usb@... to meet DTSpec > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20 ++++++++++++++++++++ > 1 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 8dd3501..19519df 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -144,6 +144,26 @@ > clocks = <&sysclk>; > }; > > + usb0: usb@3100000 { Please sort the nodes with unit-address in the address. That said, it should go after watchdog@23c0000. > + compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <0 80 0x4>; interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; Shawn > + dr_mode = "host"; > + snps,dis_rxdet_inp3_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > + }; > + > + usb1: usb@3110000 { > + compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; > + reg = <0x0 0x3110000 0x0 0x10000>; > + interrupts = <0 81 0x4>; > + dr_mode = "host"; > + snps,dis_rxdet_inp3_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > + }; > + > i2c0: i2c@2000000 { > compatible = "fsl,vf610-i2c"; > #address-cells = <1>; > -- > 1.7.1 >