Hi James/Borislav, I addressed your comments and sent out "[PATCH v3 1/2] dt-bindings: edac: arm-dmc520.txt" for review. Thanks! -Lei -----Original Message----- From: James Morse <james.morse@xxxxxxx> Sent: Monday, March 25, 2019 11:30 AM To: Rui Zhao <ruizhao@xxxxxxxxxxx> Cc: bp@xxxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-edac@xxxxxxxxxxxxxxx; okaya@xxxxxxxxxx; mchehab@xxxxxxxxxx; will.deacon@xxxxxxx; sashal@xxxxxxxxxx; Hang Li <hangl@xxxxxxxxxxxxx>; Lei Wang (BSP) <Wang.Lei@xxxxxxxxxxxxx>; Rui Zhao <ruizhao@xxxxxxxxxxxxx> Subject: Re: [PATCH v2 2/2] dt-bindings: edac: arm-dmc520.txt Hi Rui, On 07/03/2019 01:24, Rui Zhao wrote: > From: Rui Zhao <ruizhao@xxxxxxxxxxxxx> dt-bindings for new EDAC driver > dmc520_edac.c. (minor nit, the DT folk prefer the binding to come first in the series, this makes it easier to review) > diff --git a/Documentation/devicetree/bindings/edac/arm-dmc520.txt > b/Documentation/devicetree/bindings/edac/arm-dmc520.txt > new file mode 100644 > index 0000000..7bea7dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/arm-dmc520.txt > @@ -0,0 +1,21 @@ > +* ARM DMC-520 EDAC node > + > +Required properties: > +- compatible : "arm,dmc-520". > +- reg : Address range of the DMC-520 registers. > +- interrupts : DMC-520 interrupt numbers. Your example has two interrupts, what do they correspond to? (It needs to be clear from the binding) Because this thing has quite a few, it may be worth naming the ones you use. If someone else's platform uses one of the others, they can add it without conflicting with DTs for yours. Looking through the TRM for things ending in _int, they seem to be: * ram_ecc_erc * ram_ecc_erd * dram_ecc_erc * dram_ecc_erd * failed_access * failed_prog * link_err * arch_fsm * temperature_event * phy_request * combined_int I think this is far too many to enumerate from day one, especially as your platform only needs two. Could we name the two you need so that its clear which ones they are, and others can be added when someone needs them. > +- interrupt-mask : Interrupts to be enabled, refer to interrupt_control > + register in DMC-520 TRM for interrupt mapping. This sounds like policy. It would be good to omit the interrupts that aren't wired up. If there is a policy like 'use ram not dram on platform Y' we can get the edac driver to do that based on of_machine_is_compatible() (as the altera edac driver already does). > +Optional properties: > +- interrupt-shared : set this property if and only if all DMC-520 > + interrupts share the interrupt number. What if some of them are combined, and some aren't? (this shared-interrupts was my example of why we need a documented binding to work out what is specific to your platofrm) I'm not sure how this usually gets described in a DT binding ... couldn't we spot this from duplicate entries in the interrupts property? If we register them with IRQF_SHARED, would it matter? (We can always tell its our device from the status register, so I think we should use IRQF_SHARED regardless.) Thanks, James
