On Sun, May 12, 2019 at 9:41 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > Hi, > > On Sun, May 12, 2019 at 04:26:14AM -0400, Yangtao Li wrote: > > This patch adds binding document for allwinner h6 thermal controller. > > > > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx> > > --- > > .../bindings/thermal/sun50i-thermal.txt | 32 +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > We're starting to convert to YAML for binding descriptions that will > allow to validate that all DT are properly using the binding. It would > be great if you could use it as well. What have been changed to this now? > > > diff --git a/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > new file mode 100644 > > index 000000000000..67eda7794262 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sun50i-thermal.txt > > @@ -0,0 +1,32 @@ > > +Binding for Thermal Sensor of Allwinner SOC. > > + > > +This describes the device tree binding for the Allwinner thermal controller > > +which measures the on-SoC temperatures. > > + > > +Required properties: > > +- compatible: > > + - "allwinner,sun50i-h6-ths" : For H6 > > +- reg: Address range of the thermal controller > > +- clocks, clock-names: Clocks needed for the thermal controller. > > + The required clocks for h6 are: "bus". > > If there's a single clock, then we don't need clock-names Yeah, but, IIRC, H3 have two clk. So I'd like to keep it. > > > +- resets, reset-names: Reference to the reset controller controlling > > + the thermal controller. > > Ditto. Done. Thx, Yangtao > > > +- nvmem-cells: A phandle to the calibration data provided by a nvmem device. If > > + unspecified default values shall be used. > > +- nvmem-cell-names: Should be "calib" > > I thought you said that nvmem support was optional in the > driver. Maybe we could make it optional in the DT too? > > Thanks! > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
